Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[public-api] Extract BearerToken from request #9703

Merged
merged 1 commit into from
May 3, 2022
Merged

[public-api] Extract BearerToken from request #9703

merged 1 commit into from
May 3, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 2, 2022

Description

First phase of adding authentication to public API

  • We check that a token exists, but otherwise do no extra validation. This is acceptable, as we're only returning mock data at this point.
  • Eventually, this will move into a middleware and will automatically attach extracted user context into the request context, but we don't yet need this.

Related Issue(s)

How to test

  • Unit tests

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ requested a review from a team May 2, 2022 19:07
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 2, 2022
@easyCZ
Copy link
Member Author

easyCZ commented May 3, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-mp-papi-extract-bearer-token.1
(with .werft/ from main)

@easyCZ easyCZ mentioned this pull request May 3, 2022
Closed
40 tasks
@easyCZ
[public-api] Extract BearerToken from request
ab3492a 
# Conflicts:
#	components/public-api-server/pkg/apiv1/workspace_test.go
@easyCZ easyCZ force-pushed the mp/papi-extract-bearer-token branch from 3796657 to ab3492a Compare May 3, 2022 07:39
@laushinka
Copy link
Contributor

Approving! Use of the bearerToken will be in a follow-up PR.

@roboquat roboquat merged commit facd600 into main May 3, 2022
@roboquat roboquat deleted the mp/papi-extract-bearer-token branch May 3, 2022 08:48
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laushinka laushinka laushinka approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @laushinka @roboquat