[licensor] force preinstall to build liblicensor.a
#9721
Conversation
github-actions
bot
added
team: webapp
| @@ -31,6 +31,14 @@ export interface LicensePayload { | |||
| seats: number | |||
| } | |||
|
|
|||
| export enum LicenseSubscriptionLevel { | |||
There was a problem hiding this comment.
Should there be a duplicate of community and prod?
There was a problem hiding this comment.
CommunityLicense and ProfessionalLicense were introduced in the licensor code for the Gitpod license levels. This duplication exists now, since I was trying to standardize the license level names and didn't want to change the replicated code too much. We can clean it up in the future, right now this is a requirement of the existing code.
There was a problem hiding this comment.
Thanks for the quick fix, Nandaja. 🥳
I know, it's less convenient, but I think having 2 separate pull requests (one PR per concern) would help us in general. In this specific case, the discussion about the LicenseSubscriptionLevel blocks merging the build fix. Also, it wouldn't need approvals from 2 different teams. What do you think? 🤔
There was a problem hiding this comment.
@corneliusludmann I agree with one issue per PR comment. Unfortunately here, if we force the build, it will update api.ts(this file is auto-generated by genapi). Meaning that people will have a change to be staged in their workspace which is not very nice. This is a mistake on my part, not including it in the license UI PR. But the fact that changes in this PR regenerates api.ts makes this change related to the main issue.
Description
This PR fixes the current break in build when opening a workspace from
gitpodmain.licensor/typescriptcurrently do not rebuild since the build is triggered by the presence of a.afile. Since #9343 requires rebuild of theliblicensor.afile andapi.ts(built usinggenapi.go), this PR deletes the.afile to force the rebuild.Related Issue(s)
Fixes #
How to test
Open a workspace from this branch, the errors in the build should be resolved.
Release Notes
Documentation