[registry-facade] Split off port for readiness probe

[csweichel]

Description

This PR removes the port from the domain when checking if a registry host is available.

How to test

Run on a self-hosted installation where the artifact registry (not the one we push images to) is configured using a port, e.g. my-registry.location.com:8080

Release Notes

Fix readiness probe issue in registry-facace when configured registry address contains a port

[corneliusludmann]

I created a setting where I get the same error with the current release. ✔️

Then, I tried these changes. I don't know how other registries behave, however, at least with the Docker registry

curl https://registry-1.testing.gitpod-self-hosted.com:5000/gitpod/supervisor:commit-9b105e094e06575e87a19d57f1381a0dd3746d6b

returns 404 while

docker pull registry-1.testing.gitpod-self-hosted.com:5000/gitpod/supervisor:commit-9b105e094e06575e87a19d57f1381a0dd3746d6b

(after a docker login) succeeds.

Therefore, registry-facade fails now with:

{"error":null,"level":"error","message":"NetworkIsReachableProbe: unexpected status code checking URL","serviceContext":{"service":"registry-facade","version":"commit-9b105e094e06575e87a19d57f1381a0dd3746d6b"},"severity":"ERROR","statusCode":404,"time":"2022-05-03T20:08:05Z","url":"https://registry-1.testing.gitpod-self-hosted.com:5000/gitpod/supervisor:commit-9b105e094e06575e87a19d57f1381a0dd3746d6b"}

Any ideas?

[csweichel]

I've relaxed the status code requirement to accept anything below 500, i.e. 404 no longer makes the probe fail. Thanks @aledbf for the suggestion.

Supporting proper "is the image present" probes is more complicated.

[csweichel]

/werft run

👍 started the job as gitpod-build-cw-improve-regfac-probe.4
(with .werft/ from main)

[corneliusludmann]

Tested this with my self-hosted setup and it works like a charm! 🚀