Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dashboard] Minor refactor of Card and SolidCard components #9769

Merged
merged 1 commit into from
May 5, 2022
Merged

[dashboard] Minor refactor of Card and SolidCard components #9769

merged 1 commit into from
May 5, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented May 4, 2022 •
edited
Loading

Description

Minor refactor of Card and SolidCard components:

  • Fix optional custom className by adding a space
  • Allow using the full card width by not nesting children under a span element
  • Allow optionally setting a onClick handler

Tip: Reviewing without spaces is easier: https://github.com/gitpod-io/gitpod/pull/9769/files?w=1

Related Issue(s)

How to test

  1. Take a look at /admin/license -- the cards should look the same as before
BEFORE AFTER
Screenshot 2022-05-05 at 11 05 55 Screenshot 2022-05-05 at 10 42 32

Release Notes

NONE

Documentation

@jankeromnes jankeromnes requested a review from a team May 4, 2022 15:54
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 4, 2022
gtsiolis
gtsiolis approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This grabbed my attention and took a closer look. 👀

Thanks for making this refactor and including screenshots here, @jankeromnes! ✨

@jankeromnes
Copy link
Contributor Author

jankeromnes commented May 5, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Many thanks @gtsiolis! 😁 I'm re-using these components for the new Team Billing page, and needed these few small tweaks. 🔧

@roboquat roboquat merged commit 41b5dfa into main May 5, 2022
@roboquat roboquat deleted the jx/refactor-card branch May 5, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees
No one assigned
Labels
release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jankeromnes @gtsiolis @geropl @roboquat