Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[image-builder-mk3] Improve error handling #9778

Merged
merged 2 commits into from
May 4, 2022
Merged

[image-builder-mk3] Improve error handling #9778

merged 2 commits into from
May 4, 2022

Conversation

csweichel
Copy link
Contributor

@csweichel csweichel commented May 4, 2022 •
edited
Loading

Description

This PR

  • improves the error handling of image-builder-mk3. When resolving base-images against an authenticated registry, it now returns the correct error. Same goes for any other error that might happen during image resolution.
    For example: trying to pull from a registry the user is not authenticated against: image

  • introduces a basic set of unit tests for this behaviour.

  • adds support for pre-caching references from registries which require authentication.

How to test

  • see unit tests
  • try and start a workspace which attempts to pull from registry which requires authentication, without providing this authentication.

Release Notes

[image-builder] Improve error handling (no more "hostname required")

@csweichel csweichel force-pushed the cw/imgbldr-improve-errs branch 3 times, most recently from 0848ce5 to d6e68b1 Compare May 4, 2022 20:10
@csweichel csweichel force-pushed the cw/imgbldr-improve-errs branch from d6e68b1 to 3ca8b49 Compare May 4, 2022 20:21
@csweichel csweichel marked this pull request as ready for review May 4, 2022 20:27
@csweichel csweichel requested a review from a team May 4, 2022 20:27
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 4, 2022
@roboquat roboquat merged commit 747f6a9 into main May 4, 2022
@roboquat roboquat deleted the cw/imgbldr-improve-errs branch May 4, 2022 20:39
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XL team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csweichel @aledbf @roboquat