[installer] Minor alignments + fixes #9779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: delivery
geropl
force-pushed
the
gpl/minor-installer
branch
from
87e4df9 to
5836151
Compare
geropl
force-pushed
the
gpl/minor-installer
branch
from
5836151 to
540dca2
Compare
easyCZ
approved these changes
May 5, 2022
| @@ -43,7 +44,9 @@ func deployment(ctx *common.RenderContext) ([]runtime.Object, error) { | |||
| Labels: labels, | |||
| }, | |||
| Spec: corev1.PodSpec{ | |||
| Affinity: &corev1.Affinity{}, | |||
| Affinity: &corev1.Affinity{ | |||
There was a problem hiding this comment.
Does it make sense to extend the tests to check this is set correctly?
There was a problem hiding this comment.
Thx for finding this! Excellent idea, but I fear personally I won't time today, so opting for the "follow up" choice.
|
/unhold |
mrsimonemms
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains 2 minor fixes:
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation