Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[installer] Make the server mount the Github App secret #9795

Merged
merged 3 commits into from
May 5, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

One of the Webapp team's epics for Q2 is to use the Gitpod installer to deploy to Gitpod SaaS. In order to do that we will need to add additional configuration to the installer to make the output suitable for a SaaS deployment as opposed to a self-hosted deployment.

This PR adds an an extra volume and volume mount to the server component to allow it to mount the github app secret, when a github app is specified in the installer config. The ability to add github app config was added in #9297.

Related Issue(s)

Part of #9097

How to test

Create an installer config file containing this experimental section:

experimental:
  webapp:
      githubApp:
        appId: 123
        authProviderId: 'someAuthProviderId'
        baseUrl: 'someBaseUrl'
        certPath: 'someCertpath'
        enabled: true
        logLevel: 'someLogLevel'
        marketplaceName: 'someMarketPlacename'
        webhookSecret: 'somewebhookSecret'
        certSecretName: 'certSecretName'

Get a versions.yaml for use with the installer:

docker run -it --rm "eu.gcr.io/gitpod-core-dev/build/versions:${version}" cat versions.yaml > versions.yaml

Then invoke the installer as:

go run . render --debug-version-file versions.yaml --config /path/to/config --use-experimental-config

The server component will have an extra volume and volume mount

Release Notes

Make sure the server mounts the github app secret when an app is specified in the installer

Documentation

None.

Andrew Farries added 3 commits May 5, 2022 13:54
Ensure that the server pod defines a volume when a github app is
specified and that the server container mounts it.
@andrew-farries andrew-farries requested a review from a team May 5, 2022 14:54
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 5, 2022
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - looks like this might be the last PR! 🎉 😍

@roboquat roboquat merged commit 773deca into main May 5, 2022
@roboquat roboquat deleted the af/installer-server-mount-github-app-secret branch May 5, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants