[gitpod-db] add new DB entity for VolumeSnapshot #9810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team: webapp
easyCZ
reviewed
May 6, 2022
| ); | ||
| } | ||
|
|
||
| public async down(queryRunner: QueryRunner): Promise<void> { |
There was a problem hiding this comment.
Do you really want to drop the table in case we roll-back? I think here it's sensible to not drop it and keep it around, just unused. It's risky in the sense that server is never just a single replica, so we can't guarantee we won't be running code which will try to access the table and another which won't. Normally, we'd first create the table without any usage and then in later PRs, we'd start using it, such that it doesn't get dropped if the later PR needs to be reverted.
There was a problem hiding this comment.
Good question. I was following other migration examples, and thought that was the way to do it. 🤷
There was a problem hiding this comment.
@easyCZ updated. PTAL 🙏
easyCZ
approved these changes
May 9, 2022
components/gitpod-db/src/typeorm/migration/1651188368768-VolumeSnapshotCreation.ts
Outdated
Show resolved
Hide resolved
components/gitpod-db/src/typeorm/migration/1651188368768-VolumeSnapshotCreation.ts
Outdated
Show resolved
Hide resolved
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new DB entity that is used by #9475
Related Issue(s)
Part of #9475
How to test
This just adds a new entity and shouldn't affect anything else
Release Notes
Documentation