Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[server] Return NOT_FOUND when workspace does not exist #9828

Merged
merged 1 commit into from
May 10, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented May 6, 2022

Description

Because right now it returns:

"jsonrpc2: code -32603 message: Request getWorkspace failed with message: No workspace with id 'some-id' found.

which is hard to handle nicely when consuming the API.

Related Issue(s)

Fixes #

How to test

  1. On preview, run await window._gp.gitpodService.server.getWorkspace("foo") in console and observe it returns NOT_FOUND status code

Release Notes

[server] getWorkspace() returns NOT_FOUND when workspace cannot be fetched from db

Documentation

NONE

@easyCZ easyCZ requested a review from a team May 6, 2022 13:13
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 6, 2022
@easyCZ
Copy link
Member Author

easyCZ commented May 6, 2022

/werft run

👍 started the job as gitpod-build-mp-get-workspace-not-found.1
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/get-workspace-not-found branch from 0bce369 to ac2c26b Compare May 6, 2022 13:40
@easyCZ
Copy link
Member Author

easyCZ commented May 9, 2022

/werft run

👍 started the job as gitpod-build-mp-get-workspace-not-found.3
(with .werft/ from main)

@laushinka
Copy link
Contributor

laushinka commented May 10, 2022

/werft run

👍 started the job as gitpod-build-mp-get-workspace-not-found.4
(with .werft/ from main)

@laushinka
Copy link
Contributor

Approving code-wise and to not block this PR. Holding due to not being able to test yet on the preview env[1], but feel free to unhold.

@easyCZ easyCZ force-pushed the mp/get-workspace-not-found branch from ac2c26b to f66dac6 Compare May 10, 2022 12:45
@laushinka
Copy link
Contributor

laushinka commented May 10, 2022

Tested 👍🏼

@roboquat roboquat merged commit 98726d3 into main May 10, 2022
@roboquat roboquat deleted the mp/get-workspace-not-found branch May 10, 2022 13:37
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants