Laushinka/add metrics for server 9824 #9863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laushinka
force-pushed
the
laushinka/add-metrics-for-server-9824
branch
from
f4e9f40 to
e7cf60e
Compare
andrew-farries
approved these changes
May 9, 2022
Comment on lines
30
to
33
| start := time.Now() | ||
| defer func() { | ||
| ReportConnectionDuration(time.Since(start)) | ||
| }() |
There was a problem hiding this comment.
Just taught by @easyCZ 🤗
Oops wrote the wrong thing! Thanks for the catch. |
|
Thanks for helping review, @andrew-farries 🤗 |
easyCZ
requested changes
May 9, 2022
laushinka
force-pushed
the
laushinka/add-metrics-for-server-9824
branch
2 times, most recently
from
2cfc71f to
c594365
Compare
laushinka
commented
May 9, 2022
easyCZ
approved these changes
May 9, 2022
| ) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to initialize public api server: %w", err) | ||
| } | ||
|
|
||
| if registerErr := register(srv, cfg); registerErr != nil { | ||
| if registerErr := register(srv, cfg, registry); registerErr != nil { |
There was a problem hiding this comment.
Because of this part being quite not ergonomic, I've raised #9879 which allows us to do srv.MetricsRegistry() to get access to the registry. It just reduces the need to pass the registry along in a side-channel. We can update later if this PR lands first.
|
/hold /werft run 👍 started the job as gitpod-build-laushinka-add-metrics-for-server-9824.16 This PR block merge pool |
Oops didn't check the job. Thank you, @mustard-mh 🤗 |
laushinka
force-pushed
the
laushinka/add-metrics-for-server-9824
branch
from
c594365 to
aede52a
Compare
laushinka
force-pushed
the
laushinka/add-metrics-for-server-9824
branch
from
3b2cebb to
a6ef3df
Compare
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets up metric for how long a connection takes.
Related Issue(s)
Fixes #9824
How to test
/components/public-api-serverrungo run main.gocurl localhost:9500/metricsRelease Notes
Documentation