[pre-commit] Add go fmt, go mod tidy & bump versions #9870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
andrew-farries
approved these changes
May 9, 2022
Comment on lines
+43
to
+44
| - id: go-fmt | ||
| - id: go-mod-tidy |
There was a problem hiding this comment.
This seems uncontroversial to me, but this will affect all Go components owned by all teams right? So maybe ask for a wider review?
There was a problem hiding this comment.
We already validate go mod on CI when we run go mod verify, when verify fails, the fix is to run go mod tidy which this check performs. This change mostly shifts 1 CI run cycle into the workspace so it consumes less CI time (and less time for the engineer).
|
/unhold |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #
How to test
CI runs
Release Notes
Documentation
NONE