[server-ide] add label to desktop VSCode #9883
Conversation
|
@ghuntley: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/werft run 👍 started the job as gitpod-build-gh-label-vscode-desktop.1 |
| @@ -56,6 +56,7 @@ options: | |||
| orderKey: "02" | |||
| title: "VS Code" | |||
| type: "desktop" | |||
| label: "Desktop" | |||
There was a problem hiding this comment.
thought: Here's the relevant discussion and consensus reached to drop the label here. Cc @mustard-mh @loujaybee
There was a problem hiding this comment.
I prefer to add something to make desktop and browser one look different. cc @loujaybee
|
@mustard-mh, @ghuntley, @gtsiolis - I don't have a strong opinion on this issue. My bias would always be towards explicitness, so if we add If we don't get a consensus here, I'd suggest @gtsiolis have the casting vote since it's heavily design related. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Suggesting that we explicitly add a "DESKTOP" label on VSCode:
Currently
Proposed:
[pending screenshot]
How to test
Start deployment and check the label is applied.
Release Notes
Documentation