Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change imagePullPolicy to IfNotPresent #9886

Merged
merged 1 commit into from
May 12, 2022
Merged

Change imagePullPolicy to IfNotPresent #9886

merged 1 commit into from
May 12, 2022

Conversation

jenting
Copy link
Contributor

@jenting jenting commented May 10, 2022

Description

Change imagePullPolicy from Always to IfNotPresent.
We should minimize the traffic to pull container image from remote container image registry if it's already present in the cluster node.
This could avoid we hit the rate limit of the remote container image registry.

Related Issue(s)

N/A

How to test

N/A

Release Notes

None

Documentation

N/A

@jenting
Change image pull policy to IfNotPresent
07ca9a5 
Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>
@jenting jenting requested review from a team May 10, 2022 01:31
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels May 10, 2022
@jenting jenting force-pushed the jenting/change-image-pull-policy branch from 758f7e6 to 07ca9a5 Compare May 10, 2022 02:49
@jenting
Copy link
Contributor Author

jenting commented May 10, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jenting-change-image-pull-policy.3
(with .werft/ from main)

meysholdt
meysholdt approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! The change should be fine: It will not prevent new image versions from being pulled because new image versions will have a new image tag.

@roboquat roboquat merged commit 6a26be9 into main May 12, 2022
@roboquat roboquat deleted the jenting/change-image-pull-policy branch May 12, 2022 06:32
@roboquat roboquat added the deployed: IDE IDE change is running in production label May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreafalzetti andreafalzetti andreafalzetti approved these changes

@meysholdt meysholdt meysholdt approved these changes

@aledbf aledbf aledbf approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production release-note-none size/S team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jenting @aledbf @meysholdt @andreafalzetti @roboquat