Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate scopes per client #9903

Merged
merged 1 commit into from
May 13, 2022
Merged

Validate scopes per client #9903

merged 1 commit into from
May 13, 2022

Conversation

jeanp413
Copy link
Member

Description

Requesting an oauth token with a scope not listed in the scopes list of a client scopes should fail

How to test

  1. Tested directly using gitpod-desktop extension by modifying source code and requesting for an invalid scope

Release Notes

NONE

@jeanp413 jeanp413 force-pushed the jp/validate-scopes branch from effef7d to 6fc6aeb Compare May 10, 2022 16:36
@jeanp413 jeanp413 marked this pull request as ready for review May 10, 2022 18:05
@jeanp413 jeanp413 requested a review from a team May 10, 2022 18:05
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 10, 2022
@jeanp413 jeanp413 requested review from geropl and akosyakov May 10, 2022 18:06
@akosyakov
Copy link
Member

We need to test that local app and JB Gateway plugin still working with that too. @gitpod-io/engineering-ide Could someone test for regressions please?

@jeanp413
Copy link
Member Author

We need to test that local app and JB Gateway plugin still working with that too. https://github.com/orgs/gitpod-io/teams/engineering-ide Could someone test for regressions please?

@felladrin or @mustard-mh could you test this 🙏

@jeanp413
Copy link
Member Author

/hold

geropl
geropl approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, but did not test

/hold because I did not test @jeanp413 Please feel free to merge if you tested already

@akosyakov
Copy link
Member

akosyakov commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-validate-scopes.5
(with .werft/ from main)

@akosyakov
Copy link
Member

akosyakov commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-jp-validate-scopes.6
(with .werft/ from main)

@akosyakov akosyakov force-pushed the jp/validate-scopes branch from 6fc6aeb to 3050c42 Compare May 13, 2022 09:03
akosyakov
akosyakov approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked that all clients can auth

@akosyakov
Copy link
Member

/unhold

@roboquat roboquat merged commit 236f31e into main May 13, 2022
@roboquat roboquat deleted the jp/validate-scopes branch May 13, 2022 09:32
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geropl geropl geropl approved these changes

@akosyakov akosyakov akosyakov approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeanp413 @akosyakov @geropl @roboquat