ws-daemon: Remove the cpu bucket limit because we don't use #9915
Conversation
utam0k
force-pushed
the
to/remove-cpu-bucket
branch
from
8fc939b to
a3c1532
Compare
github-actions
bot
added
the
team: delivery
| @@ -222,79 +222,6 @@ func (f fixedLimiter) Limit(budgetSpent CPUTime) (newLimit Bandwidth) { | |||
| return f.FixedLimit | |||
| } | |||
|
|
|||
| // Bucket describes a "pot of CPU time" which can be spent at a particular rate. | |||
| type Bucket struct { | |||
There was a problem hiding this comment.
This is proof that it has not been used because this part has been erased and the other parts have not been changed.
|
@csweichel Any reason why you left the BucketLimit behind when you refactored CPULimit? |
utam0k
changed the title
|
/werft run with-no-preview 👍 started the job as gitpod-build-to-remove-cpu-bucket.2 |
|
/werft run 👍 started the job as gitpod-build-to-remove-cpu-bucket.3 |
|
The changes generally looks good! A small heads up to remove the |
| DynamicLimits *struct { | ||
| CPU []cpulimit.Bucket // todo(sje): add custom validation | ||
| } `json:"dynamicLimits,omitempty"` |
There was a problem hiding this comment.
Note: this is backwards incompatible change. We load the config "strictly", i.e. removing this field might break existing configuration. We don't want that.
Even though this field hasn't been used (had no effect), removing it now might break someone's config.
IMHO we should do something like this:
DeprecatedDyanmicLimits json.RawMessage `json:"dynamicLimits,omitempty" validate:"deprecated"``
and add a config validation function which returns true but emits a log message that the field is deprecated and has no effect.
|
This PR introduces incompatible changes - holding because of that /hold |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
Remove the cpu bucket limit because we don't use it. now we are using only
FixedLimiter. Saves testing and build timeRelated Issue(s)
No
How to test
Release Notes
Documentation
No