Skip to content

[dashboard] fix workspace start stuck in checking during ide onboarding #9979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roboquat merged 1 commit into from
May 13, 2022
Merged

[dashboard] fix workspace start stuck in checking during ide onboarding #9979

roboquat merged 1 commit into from
May 13, 2022

Conversation

@mustard-mh
Copy link
Contributor

@mustard-mh mustard-mh commented May 12, 2022 •
edited
Loading

Description

Workspace start will stuck in checking phase during ide awareness onboarding, this PR will fix it by add state to ask react to re-render after close Modal

Related Issue(s)

Fixes #

How to test

  1. Access preview env via https://hw-fix-ob-stuck.preview.gitpod-dev.com/#https://github.com/gitpod-io/template-sveltejs
  2. Login
  3. Choose IDE like intellj click continue
  4. See if workspace start

See also #9663

Release Notes

NONE

Documentation

@mustard-mh mustard-mh requested a review from a team May 12, 2022 15:46
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 12, 2022
@mustard-mh mustard-mh mentioned this pull request May 12, 2022
Merged
1 task
@andreafalzetti
Copy link
Contributor

andreafalzetti commented May 13, 2022

Tested in prev env and works as expected

geropl
geropl approved these changes May 13, 2022
View reviewed changes
Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested and works 🚀

@roboquat roboquat merged commit 5fadd8a into main May 13, 2022
@roboquat roboquat deleted the hw/fix-ob-stuck branch May 13, 2022 06:54
@mustard-mh
Copy link
Contributor Author

mustard-mh commented May 13, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks folks 🚀🚀🚀

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@geropl geropl geropl approved these changes

+1 more reviewer

@andreafalzetti andreafalzetti andreafalzetti approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mustard-mh @andreafalzetti @geropl @roboquat