Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing path issue of test coverate collection command #179

Merged
merged 3 commits into from
May 8, 2024

Conversation

nandajavarma
Copy link
Contributor

@nandajavarma nandajavarma commented May 8, 2024

Description

It looks like since the leeway version update on GHA runners yesterday, all new leeway builds have been failing in dedicated repo. It looks like the build only passes(specifically the collect coverage report step) if run from the directory of the package itself. It looks like the coverage.out file is created there and the go tools cover is having trouble finding packages. The error looks like:

[substrate/deployment:app] Reason: cannot collect test coverage: exit status 1: cover: no required module provides package github.com/gitpod-io/gitpod-dedicated/substrate/deployment/bootstrap: go.mod file not found in current directory or any parent directory; see 'go help modules'

This seems to be fixing it. Not entirely sure if this is the right way to go about it though

Related Issue(s)

Fixes #

How to test

Documentation

/hold

pkg/leeway/build.go Outdated Show resolved Hide resolved
@nandajavarma nandajavarma changed the title Fixing path issue Fixing path issue of test coverate collection command May 8, 2024
@nandajavarma nandajavarma requested a review from csweichel May 8, 2024 11:55
@nandajavarma nandajavarma marked this pull request as ready for review May 8, 2024 12:00
@nandajavarma nandajavarma merged commit 5d8c7c7 into main May 8, 2024
6 checks passed
@nandajavarma nandajavarma deleted the test-version branch May 8, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants