Make it possible to add new span attributes through Otel-Collector #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ArthurSens <arthursens2005@gmail.com>
ArthurSens
force-pushed
the
as/extra-span-attribute
branch
from
1bd93b4 to
f580b23
Compare
|
👋 @gitpod-io/platform -- I'm merging this one because we need to update previews with the extra attributes 🙂 |
This was referenced Sep 22, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #308
Summary
Essentially this PR splits the creation of the variable ConfigMapData into multiple small functions.
While building the processor configuration, it will check if the installer config asks for extra span attributes:
How to test
You can open a workspace from this PR, then play around with the file
installer/examples/full-config.yamlby adding or removing fields totracing.extraSpanAttributesthen running:This command will generate the file
installer/monitoring-satellite.yml, and you'll notice that Otel-collector's configmap will be written as expected