[github] show PR controller in PR context #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still lacks the case that the user hasn't granted the necessary scopes in the GitHub access yet. Should we add a notification on this? |
|
@JanKoehnlein How does it behave in such case? Nothing happens? then it would be good to add a notification. |
JanKoehnlein
force-pushed
the
jk/show_pr_controller
branch
3 times, most recently
from
8824403 to
8500a5b
Compare
JanKoehnlein
force-pushed
the
jk/show_pr_controller
branch
from
8500a5b to
fcd4351
Compare
akosyakov
reviewed
Aug 4, 2021
| vscode.commands.executeCommand('workbench.view.extension.github-pull-request'); | ||
| } | ||
| }); | ||
| await vscode.authentication.getSession('github', ['read:user', 'user:email', 'repo'], { createIfNone: true }); |
There was a problem hiding this comment.
we should a link here where to look up such scopes
jeanp413
pushed a commit
that referenced
this pull request
Sep 5, 2021
jeanp413
pushed a commit
that referenced
this pull request
Sep 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes gitpod-io/gitpod#4081