-
-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unknown option 'rebase' error #1528
Comments
Options should be passed as kwargs, the argument from pull() is a git reference (like a branch name). haven't tested if this works
|
Thanks for the quick response! We'll test out the |
We've confirmed that
and
both work. I wonder if this should have a been a bump to the major version since it changes the behavior of several of the core git methods. Admittedly, we were passing the options to the pull command incorrectly. Anyway, our tests are passing again. Thanks for the help! |
It's the trade-off between not causing surprises during automated upgrades and protecting unsuspecting uses of GitPython from harm. For critical fixes GitPython will typically choose a patch release even if these have the potential to break some users. |
Hello!
We have a project which uses GitPython to automate interacting with Git for GitOps based deployments. After the 3.1.30 release we started seeing an error in our integration tests:
We believe it was introduced with this PR.
The code that is failing is:
Any help would be greatly appreciated!
The text was updated successfully, but these errors were encountered: