Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit trailers should be a list instead of a dictionary #1533

Closed
nickbroon opened this issue Jan 10, 2023 · 2 comments
Closed

commit trailers should be a list instead of a dictionary #1533

nickbroon opened this issue Jan 10, 2023 · 2 comments

Comments

@nickbroon
Copy link

Consider for example this linux kernel commit: https://gitlab.com/linux-kernel/stable/-/commit/1382999aa0548a171a272ca817f6c38e797c458c which has following trailers that include multiple cc and signed-off-by trailers:

Link: https://lore.kernel.org/lkml/7cbe96cf-e0b5-ba63-d1b4-f63d2e826efa@suse.cz/


Cc: stable@vger.kernel.org # 6.1+
Reported-by: default avatarVlastimil Babka <vbabka@suse.cz>
Suggested-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
Acked-by: default avatarLuigi Semenzato <semenzato@chromium.org>
Cc: Peter Huewe <peterhuewe@gmx.de>
Cc: Jarkko Sakkinen <jarkko@kernel.org>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Johannes Altmanninger <aclopte@gmail.com>
Signed-off-by: Jason Donenfeld's avatarJason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>

And git interpret-trailers --parse ... will return all of these.

However the trailers() function returns a dictionary with only the last value for each token.

@itsluketwist
Copy link
Contributor

@Byron - happy for me to fix this up? 😄

@Byron
Copy link
Member

Byron commented Apr 21, 2023

Of course, that would be much appreciated. Thanks for offering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants