Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

working_dir has Optional type when it can't be None #1549

Closed
Sineaggi opened this issue Jan 27, 2023 · 1 comment · Fixed by #1550
Closed

working_dir has Optional type when it can't be None #1549

Sineaggi opened this issue Jan 27, 2023 · 1 comment · Fixed by #1550
Labels
waiting for feedback

Comments

@Sineaggi
Copy link
Contributor

In https://github.com/gitpython-developers/GitPython/blob/main/git/repo/base.py#L285 working_dir is never assigned to None, which means it type shouldn't be marked as Optional.
@Sineaggi Sineaggi mentioned this issue Jan 27, 2023
Merged
@Byron
Copy link
Member

Byron commented Jan 28, 2023

What happens when the repository is bare? Then by definition it has no working dir, and I don't think working_dir is populated anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
waiting for feedback
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove optional from two member variables Sineaggi/GitPython
2 participants
@Byron @Sineaggi