Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-41040: Blind local file inclusion #1638

Closed
EliahKagan opened this issue Aug 31, 2023 · 5 comments · Fixed by #1644
Closed

CVE-2023-41040: Blind local file inclusion #1638

EliahKagan opened this issue Aug 31, 2023 · 5 comments · Fixed by #1644

Comments

@EliahKagan
Copy link
Contributor

EliahKagan commented Aug 31, 2023

This issue is for tracking the public vulnerability CVE-2023-41040:

In order to resolve some git references, GitPython reads files from the .git directory, in some places the name of the file being read is provided by the user, GitPython doesn't check if this file is located outside the .git directory. This allows an attacker to make GitPython read any file from the system.

Further details, including example code, are in CVE-2023-41040.

(I'm opening this issue based on the idea in #1635 (comment) that it's useful to have issues for these. This CVE has been mentioned in #1635, but if #1636 is merged then #1635 may be closed. #1636 fixes CVE-2023-40590 but does not also fix CVE-2023-41040.)

@EliahKagan

This comment was marked as resolved.

@stsewd
Copy link
Contributor

stsewd commented Sep 2, 2023

I went ahead and updated the versions in the local advisories. The global advisories, one is being updated at github/advisory-database#2695, for the other one I can suggest an update at github/advisory-database#2690.

@facutuesca
Copy link
Contributor

@EliahKagan I created a PR with a possible fix for the issue

@plannigan
Copy link

It looks like the GitHub advisory was updated with the patched version information. However, the repository advisory does not show the patched version information (not sure why there is a difference).

@stsewd
Copy link
Contributor

stsewd commented Sep 9, 2023

Updated 👍

There are two types of advisories, local and global, GitHub updates the global ones, and maintainers (and looks like reporters too) can update the local ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

5 participants