You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for sharing your findings!
Indeed, the way it kills the process is SIGKILL, which as far as I know can/will(?) leave child processes detached. So killing the entire process tree seems to be the right thing to do right now. In theory, making recursive calls could work.
Stray processes could be a real issue in long running processes :/.
I am using GitPython 2.0.2.
While having kill_after_timeout in the pull()
e.g. g.pull(kill_after_timeout=10)
Before the process killing, there were four processes running:
After the timeout, (3) and (4) remained.
Should _kill_process() be recursively called like the following?
The text was updated successfully, but these errors were encountered: