-
-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop python 3.4, prep for adding types #1188
Conversation
Yobmod
commented
Feb 28, 2021
•
edited
Loading
edited
- Drop python 3.4 in setup.py and tox.ini
- Update .gitnignore
- Add mypy.ini
- Add git/py.typed file and to setup.py
- add test/testrunner.py as a hook for monkeytype
- Add git/types.py for type aliases and classes
- (Some commits just formatting. VSCode switched my flake8 off for mypy)
I've had to rename testrunner.py as it was interferring with the checks. Feel free to change to a better name! |
Thanks a lot! Please let me know if this is a draft (and I will make it a draft PR) or when it's ready to be merged as foundation for types (I really don't know much anything about that and rely solely on your expertise, thanks in advance for bearing my ignorance 😅). |
I think this is ready to merge as is. |
Thanks a lot, I am looking forward to seeing the first types :)! |
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.
It benefits from a docstring because it is not referenced in code or documentation, and its purpose is/was otherwise unclear. The docstring includes a reference to gitpython-developers#1188 for more information.