-
-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incomplete typehinting for PathLike #1474
Conversation
Thanks for adding Maybe this PR can be re-run occasionally to see if that fixes it as it should pull the latest version and fixed version of flake at some point. I also asked @Yobmod for assistance, maybe they have seen this issue before. |
Hello, please do not merge this PR as it appears the current fix might not
be correct.
As per the current fix, Pylance/mypy will complain that a str object does
not comply with the type hint. I assume it would be the same error raised
if I pass a byte object, but complaining it's not a str this time, I assume.
I need to investigate and see what else I can do, but this might be tricky.
…On Mon, Aug 1, 2022, 02:51 Sebastian Thiel ***@***.***> wrote:
Thanks for adding bytes, in theory it *should* now be ready. I myself am
not sure what's going on with flake8 except that it's probably buggy in the
latest version.
Maybe this PR can be re-run occasionally to see if that fixes it as it
should pull the latest version and fixed version of flake at some point.
—
Reply to this email directly, view it on GitHub
<#1474 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOSDPZ3QOGJQ3SPPBXZ7INDVW4NSDANCNFSM55FN4VFQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Predeactor <predeactor0@gmail.com>
Signed-off-by: Predeactor <predeactor0@gmail.com>
Thanks a lot for figuring this out with me! |
You're welcome! |
This adds a more rich type hinting for the
git.types.PathLike
class.Closes #1473.
Also remove unused imports in this file.