Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incomplete typehinting for PathLike #1474

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Fix incomplete typehinting for PathLike #1474

merged 4 commits into from
Aug 8, 2022

Conversation

madebylydia
Copy link
Contributor

This adds a more rich type hinting for the git.types.PathLike class.
Closes #1473.

Also remove unused imports in this file.

@madebylydia
Copy link
Contributor Author

I'm unsure that the check has failed due to the change because I am unable to run flake8 myself for some reasons... Even after rolling back my changes
image
I'm confused, and might require a hand on how to fix the following...

@Byron Byron requested a review from Yobmod August 1, 2022 00:47
@Byron
Copy link
Member

Byron commented Aug 1, 2022

Thanks for adding bytes, in theory it should now be ready. I myself am not sure what's going on with flake8 except that it's probably buggy in the latest version.

Maybe this PR can be re-run occasionally to see if that fixes it as it should pull the latest version and fixed version of flake at some point.

I also asked @Yobmod for assistance, maybe they have seen this issue before.

@madebylydia
Copy link
Contributor Author

madebylydia commented Aug 1, 2022 via email

Predeactor added 2 commits August 7, 2022 18:31
Signed-off-by: Predeactor <predeactor0@gmail.com>
Signed-off-by: Predeactor <predeactor0@gmail.com>
@Byron Byron merged commit 1c0f307 into gitpython-developers:main Aug 8, 2022
@Byron Byron added this to the v3.1.28 - Bugfixes milestone Aug 8, 2022
@Byron
Copy link
Member

Byron commented Aug 8, 2022

Thanks a lot for figuring this out with me!

@madebylydia
Copy link
Contributor Author

You're welcome!

@madebylydia madebylydia deleted the master branch August 8, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

git.types.PathLike is partially unknown for Pylance/mypy
2 participants