Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split tox lint env into three envs, all safe #1870

Merged
merged 4 commits into from
Mar 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,3 @@ jobs:
python-version: "3.x"

- uses: pre-commit/action@v3.0.1
with:
extra_args: --all-files --hook-stage manual
28 changes: 24 additions & 4 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
requires = tox>=4
env_list = py{37,38,39,310,311,312}, mypy, html
env_list = py{37,38,39,310,311,312}, ruff, format, mypy, html, misc

[testenv]
description = Run unit tests
Expand All @@ -9,14 +9,27 @@ extras = test
pass_env = SSH_*
commands = pytest --color=yes {posargs}

[testenv:lint]
description = Lint via pre-commit
[testenv:ruff]
description = Lint with Ruff
base_python = py{39,310,311,312,38,37}
commands = pre-commit run --all-files --hook-stage manual
deps = ruff
set_env =
CLICOLOR_FORCE = 1 # Set NO_COLOR to override this.
commands = ruff check .

[testenv:format]
description = Check formatting with Ruff
base_python = py{39,310,311,312,38,37}
deps = ruff
set_env =
CLICOLOR_FORCE = 1 # Set NO_COLOR to override this.
commands = ruff format --check .

[testenv:mypy]
description = Typecheck with mypy
base_python = py{39,310,311,312,38,37}
set_env =
MYPY_FORCE_COLOR = 1
commands = mypy -p git
ignore_outcome = true

Expand All @@ -28,3 +41,10 @@ allowlist_externals = make
commands =
make BUILDDIR={env_tmp_dir}/doc/build -C doc clean
make BUILDDIR={env_tmp_dir}/doc/build -C doc html

[testenv:misc]
description = Run other checks via pre-commit
base_python = py{39,310,311,312,38,37}
set_env =
SKIP = ruff-format,ruff
commands = pre-commit run --all-files
Loading