Skip to content

Fix ambiguous _safer_popen_windows comment #2044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025
Merged

Fix ambiguous _safer_popen_windows comment #2044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions git/cmd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,12 +273,12 @@ def _safer_popen_windows(
if shell:
# The original may be immutable, or the caller may reuse it. Mutate a copy.
env = {} if env is None else dict(env)
env["NoDefaultCurrentDirectoryInExePath"] = "1" # The "1" can be an value.
env["NoDefaultCurrentDirectoryInExePath"] = "1" # The "1" can be any value.

# When not using a shell, the current process does the search in a
# CreateProcessW API call, so the variable must be set in our environment. With
# a shell, that's unnecessary if https://github.com/python/cpython/issues/101283
# is patched. In Python versions where it is unpatched, and in the rare case the
# is patched. In Python versions where it is unpatched, in the rare case the
# ComSpec environment variable is unset, the search for the shell itself is
# unsafe. Setting NoDefaultCurrentDirectoryInExePath in all cases, as done here,
# is simpler and protects against that. (As above, the "1" can be any value.)
Expand Down
Loading