Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency not updated for smmap in install_requires #69

Closed
phlax opened this issue Mar 26, 2021 · 4 comments
Closed

Dependency not updated for smmap in install_requires #69

phlax opened this issue Mar 26, 2021 · 4 comments
Labels
acknowledged

Comments

@phlax
Copy link

phlax commented Mar 26, 2021

Not sure if this is by intention or omission, but the dependency on smmap is updated in requirements.txt but not in install_requires of setup.py

gitdb/setup.py

Line 23 in aa7228e

install_requires=['smmap>=3.0.1,<4'],

@phlax phlax mentioned this issue Mar 26, 2021
Merged
@Harmon758
Copy link
Member

Ah, I missed this in #68. I'll bump it for a v4.0.7 release.

@phlax
Copy link
Author

phlax commented Mar 26, 2021

great thanks

@Harmon758
Copy link
Member

@Byron v4.0.7 (6b997cd) is ready to be released to fix this.

@Byron
Copy link
Member

Byron commented Mar 26, 2021

Thanks everyone! The release is now live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
acknowledged
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Byron @phlax @Harmon758