Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumped smmap upper bound #68

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Bumped smmap upper bound #68

merged 1 commit into from
Mar 25, 2021

Conversation

tmcclintock
Copy link
Contributor

Closes #67

Tests passed locally.

@tmcclintock tmcclintock mentioned this pull request Mar 24, 2021
Closed
Byron
Byron requested changes Mar 25, 2021
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a bunch!

Could you also increase the gitdb version number to something you find suitable for such a change?
My problem is that I don't really know what's going on and why things are breaking down as they do, originally @Harmon758 did tremendous work to assure of that.

Harmon758
Harmon758 approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@Harmon758 Harmon758 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Byron A patch version bump should be fine for this.

@Harmon758 Harmon758 merged commit c5feb3d into gitpython-developers:master Mar 25, 2021
@Byron
Copy link
Member

Byron commented Mar 25, 2021

Thanks, @Harmon758 , I just published v4.0.6, unfortunately along with 4.0.5 as that one was apparently still lying around locally. It's interesting to see how pypi allows overwriting/altering already published versions. Let's hope that doesn't break things.

View at:
https://pypi.org/project/gitdb/4.0.6/
https://pypi.org/project/gitdb/4.0.5/

@Harmon758
Copy link
Member

v4.0.5 was already released on May 4, 2020, and you can't alter or overwrite existing releases, so I don't think anything happened with that version.

@Harmon758 Harmon758 mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron requested changes

@Harmon758 Harmon758 Harmon758 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update requirements for smmap
3 participants
@tmcclintock @Byron @Harmon758