Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize & write better CSS #3504

Open
mittalyashu opened this issue Jul 29, 2019 · 0 comments
Open

Organize & write better CSS #3504

mittalyashu opened this issue Jul 29, 2019 · 0 comments
Assignees
Labels

Comments

@mittalyashu
Copy link
Member

mittalyashu commented Jul 29, 2019

We are using SASS pre-process to write CSS styles, here's are a few examples of styles:

Classes Styles
1 repository_settings vue carbon (1)
2 carbon carbon (2)

The quality of the CSS needs to be improved, in terms of CSS class names and by applying some CSS principle.

We are using the BEM to write the CSS class name, and they also need to be re-named for a better understanding of each class name.

There are few styles which we still wrote in native .sass files, those styles also need to move to .vue file or make a separate component out of it.

CSS Principles

Grouping properties

background:
  color: #6d695c
  image: url("/img/argyle.png")
  size: 70px 120px
border-radius:
  top-left: 8px
  top-right: 10px
  bottom-right: 54px
  bottom-right: 10px

Colour Declarations

You might see a lot inside the Thermal codebase where color is used by its keyword name white and black. Keep the color value in rgba(255, 255, 255, .5), so even if we want to change increase the transparency in the color we have to just decrease the value of the fourth parameter.

Please: Do share your feedback/suggestion about how we can further improve the CSS.

@mittalyashu mittalyashu added ⚙ Improvement New feature or request good first issue Good for newcomers Front end 🚶🏻‍♀️ Priority low Work on it if possible labels Jul 29, 2019
@mittalyashu mittalyashu added hacktoberfest Contribute and get a chance to win *free t-shirt and stickers. difficulty: hard labels Oct 3, 2019
@mittalyashu mittalyashu removed the hacktoberfest Contribute and get a chance to win *free t-shirt and stickers. label Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants