Refactor CSS (some pages and components) #3574
Conversation
|
stylelint analysis of 60d1c45 failed. posted by Sider |
|
Your changes also include formating and indentation. Can you also run |
|
stylelint analysis of 255609e failed. posted by Sider |
|
stylelint analysis of 56b991c failed. posted by Sider |
|
Can you also remove all the transition related styles? We do have plans to animations and transition but not right now. |
|
stylelint analysis of e5d027a failed. posted by Sider |
|
stylelint analysis of 4de2fdc failed. posted by Sider |
mittalyashu
changed the title
|
|
||
| @for $i from 1 through 10 | ||
| .mt-#{$i} | ||
| margin-top: $i + rem | ||
|
|
||
| @for $i from 1 through 10 | ||
| .ml-#{$i} | ||
| margin-left: $i + rem | ||
|
|
||
| @for $i from 1 through 10 | ||
| .mb-#{$i} | ||
| margin-bottom: $i + rem | ||
|
|
||
| @for $i from 1 through 10 | ||
| .mr-#{$i} | ||
| margin-right: $i + rem |
There was a problem hiding this comment.
Creating for loop for margins might take a lot of space in terms of file size and we can easily add those to class based css inside components files.
This is a start of #3504
I need to know if I am doing it right and know if is another better way to do it 🐱🏍.
I will be waiting for some feedback!