Skip to content

Use popup_up and popup_down keys in the Log search popup #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
auvred opened this issue Aug 23, 2023 · 1 comment
Closed

Use popup_up and popup_down keys in the Log search popup #1831

auvred opened this issue Aug 23, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@auvred
Copy link

auvred commented Aug 23, 2023

Describe the bug
The LogSearchPopupComponent was introduced in the #1800. But for some reason in this popup move_up and move_down keys are used for navigation instead of popup_up and popup_down. This may conflict with vim-like key bindings, e.g I want to type j but this just moves selection down

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Log'
  2. Press f

Expected behavior
It would be great to be able to type search query even if move_up and move_down are remapped to j and k

Screenshots
image
Additional context

https://github.com/extrawurst/gitui/blob/7558d25e257fac9572582dce7e2aec39b69be2b0/src/components/log_search_popup.rs#L373-L380

The FuzzyFindPopup uses popup_up and popup_down for such movements:
https://github.com/extrawurst/gitui/blob/7558d25e257fac9572582dce7e2aec39b69be2b0/src/components/fuzzy_find_popup.rs#L362-L372

Also I guess the navigate_tree should be changed to scroll_popup, because only vertical scrolling is supported there
https://github.com/extrawurst/gitui/blob/7558d25e257fac9572582dce7e2aec39b69be2b0/src/components/log_search_popup.rs#L331

I will be glad to submit a PR if this is not intentional behavior :)

@auvred auvred added the bug Something isn't working label Aug 23, 2023
@extrawurst
Copy link
Collaborator

very good catch, thank you!

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this issue Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants