-
-
Notifications
You must be signed in to change notification settings - Fork 610
add fuzzy finder in branch list #1658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add fuzzy finder in branch list #1658
Conversation
Thanks for tackling this. This PR is already in very good shape. My comments are mostly nitpicky (aside the common base maybe). let me know if you feel up for the extraction part. if not I would like this to be merged without it to make it part of the next release |
Thank you for your review. |
let me know when its ready for the final review |
Ok, when it's ready for the final review, I re-request review. Before that, I have a small question.
|
ad175a2
to
c6d8a4a
Compare
It is now ready for review. |
Thanks a lot! |
I had completely forgotten about the changelog. 🙇♂️ |
* add branch_find_popup * capital F for fetch in branchlist, f for find * add command info of return closes gitui-org#1350
This PR is related to #1350.
Hi @extrawurst,
Sorry for my poor English. But I have a small PR!
I implemented a fuzzy finder pop-up in the branch list.
This may make it easier to find the branch you want to select.
Instead of a pop-up, we could implement as an embedded finder in the branch list, but I don't think this is a good idea as it would change the look and feel a lot.
So I have implemented it as a pop-up.
The implementation is almost the same as file_find_popup.
It changes the following:
Here is how it works in the implementation in this PR.

I followed the checklist:
make check
without errors