Skip to content

add fuzzy finder in branch list #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 21, 2023

Conversation

UUGTech
Copy link
Contributor

@UUGTech UUGTech commented Apr 18, 2023

This PR is related to #1350.

Hi @extrawurst,

Sorry for my poor English. But I have a small PR!
I implemented a fuzzy finder pop-up in the branch list.
This may make it easier to find the branch you want to select.

Instead of a pop-up, we could implement as an embedded finder in the branch list, but I don't think this is a good idea as it would change the look and feel a lot.
So I have implemented it as a pop-up.
The implementation is almost the same as file_find_popup.

It changes the following:

  • add branch finder popup to branchlist component

Here is how it works in the implementation in this PR.
gitui_branch_find_popup

I followed the checklist:

  • I added unittests
  • I ran make check without errors
  • I tested the overall application
  • I added an appropriate item to the changelog

@extrawurst
Copy link
Collaborator

Thanks for tackling this. This PR is already in very good shape. My comments are mostly nitpicky (aside the common base maybe). let me know if you feel up for the extraction part. if not I would like this to be merged without it to make it part of the next release

@UUGTech
Copy link
Contributor Author

UUGTech commented Apr 19, 2023

Thank you for your review.
I replied to your comments.
If I make common base for fuzzy_find, the picky issues of FileFindPopup I commented in reply also will be solved.
I'll work on that.

@extrawurst
Copy link
Collaborator

let me know when its ready for the final review

@UUGTech
Copy link
Contributor Author

UUGTech commented Apr 19, 2023

Ok, when it's ready for the final review, I re-request review.

Before that, I have a small question.
Which is better command info?

Scroll[...] Close[⎋] Close[⏎]
Scroll[...] Close[⎋⏎]

@UUGTech UUGTech force-pushed the feat-fuzzy-find-in-branch-list branch from ad175a2 to c6d8a4a Compare April 20, 2023 13:18
@UUGTech
Copy link
Contributor Author

UUGTech commented Apr 20, 2023

It is now ready for review.
Command info is now Scroll[...] Close[⎋⏎].
If you think this is not good, I will fix it.
Otherwise, you can merge this.

@UUGTech UUGTech requested a review from extrawurst April 20, 2023 13:26
@extrawurst extrawurst merged commit 3a6f292 into gitui-org:master Apr 21, 2023
@extrawurst
Copy link
Collaborator

Thanks a lot!

@extrawurst
Copy link
Collaborator

extrawurst commented Apr 22, 2023

added changelog entry for you including gif showcase:

Screenflick Movie 9

@UUGTech
Copy link
Contributor Author

UUGTech commented Apr 22, 2023

I had completely forgotten about the changelog. 🙇‍♂️
Thank you so much!

IndianBoy42 pushed a commit to IndianBoy42/gitui that referenced this pull request Jun 4, 2024
* add branch_find_popup
* capital F for fetch in branchlist, f for find
* add command info of return

closes gitui-org#1350
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants