-
-
Notifications
You must be signed in to change notification settings - Fork 607
Improve error messages #2617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error messages #2617
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
I just found out why - Installing v1.0.9 fixes this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this. This clearly improves error handling. For a non-repo folder, we get / got:
For dubious ownership, the original cause here, we get / got /git says:
I'd almost argue that the new message is better than what git says. "Let's just ignore this security feature with this command" maybe is not soooo cool. ;)
I have to pick on one thing, though. The panic handler was there for a reason, as far as I can tell. See my remark below.
Also, would you please be so kind and add a changelog entry? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the duplicate panic issue. @extrawurst, you added this initially, you probably have an opinion yourself.
Ok I tested the extra error handler for rayon is not needed as far as i can see. removed in on master. @acuteenvy please rebase and then we can merge this |
This Pull Request fixes/closes #2599.
It changes the following:
panic::set_hook
already handles all panics. Setting both panic handlers causes the panic message to be displayed twice.log::error!
andeprintln!
wherever possibleI followed the checklist:
make check
without errorsI get some errors in(see Improve error messages #2617 (comment))Cargo.toml
, but it hasn't been changed in this PR: