Remove dead code in RemoteListPopup::draw_selected_remote_details() #2739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only nightly CI found it[1], locally the lint didn’t fail, but that code is definitely dead code so let’s remove it. Modifying a POD struct like Rect and then doing nothing with it makes no sense. [1] https://github.com/gitui-org/gitui/actions/runs/18585963642/job/52989807824?pr=2727#step:8:694
|
Seems these changes were already made on master |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only nightly CI found it, locally the lint didn’t fail, but that code is definitely dead code so let’s remove it. Modifying a POD struct like
Rectand then doing nothing with it makes no sense.This fixes CI for all newer PRs (such as the updated #2727).
This Pull Request fixes/closes no reported issue.
It changes the following:
I followed the checklist:
make checkwithout errors (onig_sys v69.8.1 doesn’t build on my system, it fails due to some C signature incompatibilities, which shouldn’t be relevant for this fix)