Skip to content

Conversation

@cruessler
Copy link
Collaborator

@cruessler cruessler commented Oct 23, 2025

This PR updates gix to its latest version, as of 2025-10-23. This update removes 2 or 3 transitive dependencies, but it duplicates a couple more. Since this is something I know we’re concerned about, what’s the best strategy to handle this? Another option I haven’t tried yet is upgrading to an older version, hoping it introduces less duplicate dependencies.

@extrawurst
Copy link
Collaborator

moving forward gix is a higher priority. if the binary size does not explode with whatever dupes it introduces I am fine. but the CI needs to get green first :)

@cruessler
Copy link
Collaborator Author

Perfect, then I’ll go ahead! :-)

We recently moved to MSRV 1.82 in gitoxide which is why all the tests that run on 1.81 fail. We could update to a version that supports 1.81 or update our own MSRV. What do you think?

Linting fails because it includes cargo deny which I would fix once we’ve decided what to do with respect to the MRSV.

@extrawurst
Copy link
Collaborator

lets raise the MSRV to 1.82 then

@cruessler
Copy link
Collaborator Author

lets raise the MSRV to 1.82 then

I’ll update the PR tomorrow!

@cruessler cruessler requested a review from extrawurst October 27, 2025 10:01
Copy link
Collaborator

@extrawurst extrawurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just one question

@extrawurst extrawurst merged commit db211e5 into gitui-org:master Oct 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants