fix hook panicking #396
Merged
fix hook panicking #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pm100 could you gives this a go on a vanilla windows? |
|
I have to work out some fancy git footwork :) |
|
i am stumped at the moment, this has reached the edge of my git know how. I have to pull from your patch branch into my hook patch branch and resolve conflicts. I suspect I have messed that up cos it still crashes. A total git noob. I will have another go tomorrow. Family calls. |
|
@pm100 this change makes sense anyway since this is a clear situation where stuff can panic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #393