Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of template literals with expressions #13

Merged
merged 5 commits into from
Mar 29, 2017
Merged

Fix handling of template literals with expressions #13

merged 5 commits into from
Mar 29, 2017

Conversation

alethes
Copy link
Contributor

@alethes alethes commented Mar 24, 2017

Fixes #8.

@giuseppeg
Copy link
Owner

hey @alethes thanks! Can you add (copy) the tests from #11 to this PR?

@alethes
Copy link
Contributor Author

alethes commented Mar 28, 2017

Hey @giuseppeg, I've merged the expressions branch, removed the console.log calls and fixed minor differences between the fixture and the actual output.

@giuseppeg giuseppeg merged commit b9576f2 into giuseppeg:master Mar 29, 2017
@giuseppeg
Copy link
Owner

thanks a lot for looking into this @alethes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alethes @giuseppeg