Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS-StartPortForwardingSessionToRemoteHost #54

Merged
merged 1 commit into from
Jul 13, 2022
Merged

Add AWS-StartPortForwardingSessionToRemoteHost #54

merged 1 commit into from
Jul 13, 2022

Conversation

andymac4182
Copy link
Contributor

@andymac4182 andymac4182 commented Jun 8, 2022 •
edited
Loading

#52

Add support for AWS-StartPortForwardingSessionToRemoteHost

@andymac4182 andymac4182 marked this pull request as ready for review June 13, 2022 12:36
@andymac4182 andymac4182 mentioned this pull request Jun 13, 2022
Open
n3mawashi
n3mawashi approved these changes Jun 13, 2022
View reviewed changes
Copy link

@n3mawashi n3mawashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code. Function test would be my only feedback

@andymac4182
Copy link
Contributor Author

Thanks @n3mawashi Copied from existing and hard to test against AWS :(

@isaac4577
Copy link

This is a great PR!
By cloning this branch, building and executing gossm fwdrem, I've verified that I can successfully connect to the DB in my private subnet.
I hope this PR will be merged as soon as possible. 🤗

@andymac4182
Copy link
Contributor Author

Thanks for testing @isaac4577

@andymac4182
Copy link
Contributor Author

@gjbae1212 Can you please review?

This follows the same pattern as gossm fwd with the added parameter for the remote host.

gjbae1212
gjbae1212 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Owner

@gjbae1212 gjbae1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GOOD 👍

LGTM

@gjbae1212 gjbae1212 merged commit f96bb31 into gjbae1212:master Jul 13, 2022
@andymac4182
Copy link
Contributor Author

Thanks @gjbae1212 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjbae1212 gjbae1212 gjbae1212 approved these changes

@n3mawashi n3mawashi n3mawashi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andymac4182 @isaac4577 @gjbae1212 @n3mawashi