WIP for issue #82 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdamian
reviewed
Mar 14, 2023
| @@ -241,6 +244,18 @@ class ConfigError(Exception): | |||
| Opt("jobs"): Seq(Map(_job_schema_dict)), | |||
| Opt("web"): Map({"listen": Seq(Str())}), | |||
| Opt("include"): Seq(Str()), | |||
| Opt("logging"): Map( | |||
There was a problem hiding this comment.
In favor of future upgrades, could there by just YamlAny?
There was a problem hiding this comment.
Hah, yes, and no. I started doing just that, before discovering a "unfun" fact about scrityaml. When you use the "any" validator, all yaml values become strings. In this particular example, the version field was a string, and python's logging didn't like that, it has to be an int. Took me a while to understand that nuance. Declaring the field as Int() fixes that.
The nested objects are declared YamlAny, which seems to work so far, but I fear the string-ification issue might rear its ugly head again in the future 😕
|
Ah, ok! I wasn't aware of such behaviour. Hope no issues with that would
occur in future :)
wt., 14 mar 2023, 17:09 użytkownik Gustavo J. A. M. Carneiro <
***@***.***> napisał:
… ***@***.**** commented on this pull request.
------------------------------
In yacron/config.py
<#83 (comment)>:
> @@ -241,6 +244,18 @@ class ConfigError(Exception):
Opt("jobs"): Seq(Map(_job_schema_dict)),
Opt("web"): Map({"listen": Seq(Str())}),
Opt("include"): Seq(Str()),
+ Opt("logging"): Map(
Hah, yes, and no. I started doing just that, before discovering a "unfun"
fact about scrityaml. When you use the "any" validator, all yaml values
become strings. In this particular example, the version field was a
string, and python's logging didn't like that, it has to be an int. Took me
a while to understand that nuance. Declaring the field as Int() fixes
that.
The nested objects are declared YamlAny, which *seems* to work so far,
but I fear the string-ification issue might rear its ugly head again in the
future 😕
—
Reply to this email directly, view it on GitHub
<#83 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA7KV46BXFOEMWYVHE23PGLW4CJ27ANCNFSM6AAAAAAVWTX65Q>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.