Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jna dependency to restore native file watching on Macs #14

Closed
wants to merge 1 commit into from

Conversation

rgm
Copy link

@rgm rgm commented Aug 4, 2020

Mac OS 11 (aka. "Big Sur") made some changes to the way that the Carbon library is located, causing JNA calls to fail. This has been fixed in JNA 5.6.0; see java-native-access/jna#1216

Since Barbary is implemented on JNA, this is causing downstream projects that rely on file watching to crash on JVM start when used on Mac OS 11.

Examples:

Mac OS 11 (aka. "Big Sur") made some changes to the way that the Carbon
library is located, causing JNA calls to fail. This has been fixed in
JNA 5.6.0; see java-native-access/jna#1216

Since Barbary is implemented on JNA, this is causing downstream projects
that rely on file watching to crash on JVM start when used on Mac OS 11.

Examples:
- bhauman/figwheel-main#253
- thheller/shadow-cljs#767
@gjoseph
Copy link
Owner

gjoseph commented Aug 5, 2020

@rgm thanks for this. As you may gather from the utter lack of responses on my end on issues/PRs in a while, I've sorta stopped maintaining this - having no current need for the library since a few years makes it easy to forget about it.

The change looks good, and indeed much needed. However if the minimum Java version has to change to support this (as per the change to the compiler configuration in pom.xml), I'd suggest a note in the README (which currently explicitly says "for Java 6"). FWIW I tried a while ago to get a CI setup running on OSX (one the CI providers at the time was offering OSX builds, but I don't know where that's at today), which would also be good to have for this sort of change.

@gjoseph
Copy link
Owner

gjoseph commented Aug 5, 2020

Actually, PR#11 seems to be solving some of the build issues I was mentioning, if you're keen to have a look at that

@rgm
Copy link
Author

rgm commented Aug 5, 2020

Actually, PR#11 seems to be solving some of the build issues I was mentioning, if you're keen to have a look at that

Can do. 👍

On reflection, I'm not actually sure I need to bump the min Java version. It might just be an artifact of what I needed to do with my locally available Java versions to get mvn test to run. But it's hard to tell without CI so I'll go look at #11.

@gjoseph
Copy link
Owner

gjoseph commented Mar 25, 2022

Hi @rgm sorry for the slow response -- as you may have gathered, I haven't had capacity to maintain this project in a long time. I'm finally officially retiring it. See README for possible alternatives, if you're still needing this. ✌️

@gjoseph gjoseph closed this Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants