Update base URL regex to make show with paths with 'notebook' in them #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses a lazy (non-greedy) regex modifier, to ensure that the first 'notebook' (or 'lab' etc) in the URL is matched not the last.
gjoseph92
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the regex used by the
base_url_from_window_locationfunction. This function tries to determine the base URL of the Jupyter server, but previously failed if the path to the current notebook includednotebook(orlaborvoila). This PR changes the regex to be a 'lazy' or 'non-greedy' regex which means it will match the first occurrence ofnotebook/lab/etc rather than the last - and therefore extract the correct base URL.