Skip to content

Commit

Permalink
Address part of feedback for microsoft#100993
Browse files Browse the repository at this point in the history
  • Loading branch information
Rachel Macfarlane authored and gjsjohnmurray committed Jul 9, 2020
1 parent ba9b85b commit 9e83584
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/vs/vscode.proposed.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ declare module 'vscode' {
/**
* The human-readable name of the account.
*/
readonly label: string;
readonly displayName: string;

/**
* The unique identifier of the account.
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/api/browser/mainThreadAuthentication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export class MainThreadAuthentication extends Disposable implements MainThreadAu
if (sessions.length) {
if (!this.authenticationService.supportsMultipleAccounts(providerId)) {
const session = sessions[0];
const allowed = await this.$getSessionsPrompt(providerId, session.account.label, label, extensionId, extensionName);
const allowed = await this.$getSessionsPrompt(providerId, session.account.displayName, label, extensionId, extensionName);
if (allowed) {
return session;
} else {
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/api/common/extHostAuthentication.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export class ExtHostAuthentication implements ExtHostAuthenticationShape {
if (sessions.length) {
if (!provider.supportsMultipleAccounts) {
const session = sessions[0];
const allowed = await this._proxy.$getSessionsPrompt(providerId, session.account.label, provider.label, extensionId, extensionName);
const allowed = await this._proxy.$getSessionsPrompt(providerId, session.account.displayName, provider.label, extensionId, extensionName);
if (allowed) {
return session;
} else {
Expand Down

0 comments on commit 9e83584

Please sign in to comment.