Fix issues with tables during a round-trip parsing CM and then producing CM again. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! ❤️ |
|
That was a slightly quicker response than I was anticipating :) |
|
:D I happen to be awake and my mail client was open! |
|
😃 |
That's because @kivikakk is amazing. 🤓 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing Commonmark, traversing the nodes and then re-generating Commonmark, table rows longer than 120 characters are broken as a result of the hard-coded column wrapping.
This patch introduces an optional rendering parameter to specify the width, so callers can opt for "0" to omit all wrapping when necessary (or choose a different wrapping column as desired).