Fix cmake rules to really install executable and libraries #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I should note that I don't have much experience with CMake, so I'm not sure if this solution is _correct_. However, it works as expected. Fixes #58
|
Can you merge this pull request? |
|
I cannot/will not merge a PR with failing CI tests. Having said that I don't think the failures are specific to this branch, but just in case, it'll take time to investigate and fix the problem. For example, it looks like the Appveyor Windows builds are having trouble downloading flex and bison for some reason. |
|
Oof, and the macOS error is from a memory leak: #62 |
|
Thank you for your contribution, @jirutka ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should note that I don't have much experience with CMake, so I'm not
sure if this solution is correct. However, it works as expected.
Fixes #58