Use setlocal over set to contain changes to buffer
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffharcourt
force-pushed
the
gh-fix-setlocal-iskeyword
branch
from
3535cee
to
8d84923
Compare
Using `set isk` changes rules about what characters count as keywords in buffers that don't contain CSS. Plugins should use `setlocal` for to change settings for a buffer. Updated the command invocation to use `iskeyword` to improve clarity about what the function is doing. Fix gko#20. Fix gko#22. Fix gko#26.
geoffharcourt
force-pushed
the
gh-fix-setlocal-iskeyword
branch
from
8d84923
to
304ced6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
set iskchanges rules about what characters count as keywords inbuffers that don't contain CSS. Plugins should use
setlocalfor tochange settings for a buffer.
Updated the command invocation to use
iskeywordto improveclarity about what the function is doing.
Fix #22. Close #20