Implement simultaneous camera connect #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lay the foundation for supporting simultaneous, parallel camera connections. The UI now sends commands to the control task, which relays them to per-camera tasks. This allows the UI and each connected camera to operate asynchronously. Increase limit maximum clients from 3 to 8.
Fix #100 by updating to a development cut of NimBLE-Arduino. Whilst here improve device bond handling, this makes subsequent pair/forget sequences a little less iffy.
M5ez: Add context to menu item advanced function. Furble: Tweak NimBLE settings. Remove scan duration, now scan forever as we can stop on demand. Drop global interval_t, load as needed to reduce variable scope. Add setting to toggle multi-connect. Modify connection menu to support tagging cameras. Add ability to connect to all tagged cameras. Cannot get directed advertising to mobile devices so still disabled. Multi-connect to mobile devices is super iffy, not recommended for production use.
Fix minor error in shutter lock formatting, introduced when migrating from String to std::string. Also removed unused macros.
This was
linked to
issues
Sep 16, 2024
Move some more code into std::string native and const a few more parameters.
Refactor the Camera type into the base Camera class. Refactor fillSaveName into CameraList class, it is only used there. Style adjustments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add per-camera task and queue.
Modify control task to act as proxy to each camera, thereby completely divorcing the UI from interfering with camera bluetooth traffic.
Add setting to enable 'Multi-Connect', defaults to false.
Refactor connect menu to handle multiple camera selection and connection.
Minimally tested with 2 targets, should work with up to 9.
Also fix the mobile device name by updating NimBLE-Arduino to development version.