Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25 refactor canon eos support #26

Merged
merged 4 commits into from
Nov 15, 2022
Merged

25 refactor canon eos support #26

merged 4 commits into from
Nov 15, 2022

Conversation

gkoh
Copy link
Owner

@gkoh gkoh commented Nov 13, 2022

No description provided.

@gkoh
Refactor Canon EOS support.
0b59160 
Implement a Canon EOS base class and derive the M6 and RP from it.
Whilst here, refactor the focus button handling such that there is are
separate 'focusPress' and 'focusRelease' methods.
@gkoh
Attempt to implement focus support for Canon EOS.
e34590f
@gkoh gkoh linked an issue Nov 13, 2022 that may be closed by this pull request
Refactor Canon EOS support #25
Closed
@gkoh
Copy link
Owner Author

gkoh commented Nov 13, 2022

@wolcano Are you in a position to test this PR?
I've refactored the code so M6 and RP share code now.
Additionally, I was looking at other projects and I seem to recall what I called 'shutterPress' is actually 'focus'.
So, I've broken it up for both Fuji and Canon, there's now 'shutterPress/shutterRelease' and 'focusPress/focusRelease'.

If I'm right, button 'A' will now:

  • trigger focus
  • trigger the shutter

And button 'B' will:

  • trigger focus only

@wolcano
Copy link
Contributor

wolcano commented Nov 13, 2022

both A and B focus and trigger shutter

@gkoh
Copy link
Owner Author

gkoh commented Nov 13, 2022

both A and B focus and trigger shutter

Damn, guess I’m wrong. Thanks for trying.

@gkoh
Copy link
Owner Author

gkoh commented Nov 15, 2022

both A and B focus and trigger shutter

Damn, guess I’m wrong. Thanks for trying.

I created #29 to track this properly.
I think this refactor is worth merging as-is.

@gkoh gkoh merged commit f220019 into master Nov 15, 2022
@gkoh gkoh deleted the 25-refactor-canon-eos-support branch November 15, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Canon EOS support
2 participants
@gkoh @wolcano