Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gl-shader unlock #11

Merged
merged 3 commits into from
Jan 25, 2018
Merged

gl-shader unlock #11

merged 3 commits into from
Jan 25, 2018

Conversation

dy
Copy link
Member

@dy dy commented Jun 14, 2017

We have to unbind gl-vao's in order to avoid warnings in console, which was the issue preventing from bumping gl-shader version. Still have to figure out why it happens so with unbound gl-vao, but here it is must-do patch.

TODO:

Supercedes #10

@etpinard I can do patches to according repos to unlock gl-shader version

@dy
Copy link
Member Author

dy commented Jun 14, 2017

Ok, seems that it breaks some plotly tests. Still have to figure out the reason.

@dy
Copy link
Member Author

dy commented Jun 14, 2017

False triggering, tests pass successfully. @etpinard may I ask you to check once you have a minute?

@etpinard
Copy link
Member

Sure. But, that won't happen until 1.28.0 is out.

@jwerle
Copy link

jwerle commented Jun 20, 2017

excited to see this happen

@dy
Copy link
Member Author

dy commented Jun 22, 2017

@etpinard should we proceed with that?

etpinard added a commit to plotly/plotly.js that referenced this pull request Jul 17, 2017
etpinard added a commit to plotly/plotly.js that referenced this pull request Jul 17, 2017
@etpinard
Copy link
Member

@dfcreative see https://github.com/plotly/plotly.js/compare/unlock-gl-shader

This patch here along with gl-vis/gl-error3d#4 and gl-vis/gl-mesh3d#12 generate a few diffs in our image tests:

image

Most notably gl3d_log-axis, which is missing a trace:

image

compared to

image

on master (see http://rickyreusser.com/plotly-mock-viewer/#gl3d_log-axis)

@dy
Copy link
Member Author

dy commented Jan 25, 2018

Since all tests are passing at plotly/plotly.js#2293, merging.

@dy dy merged commit 27c1335 into master Jan 25, 2018
@dy dy deleted the gl-shader-unlock branch January 25, 2018 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants