-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gl-shader unlock #11
gl-shader unlock #11
Conversation
Ok, seems that it breaks some plotly tests. Still have to figure out the reason. |
False triggering, tests pass successfully. @etpinard may I ask you to check once you have a minute? |
Sure. But, that won't happen until |
excited to see this happen |
@etpinard should we proceed with that? |
@dfcreative see https://github.com/plotly/plotly.js/compare/unlock-gl-shader This patch here along with gl-vis/gl-error3d#4 and gl-vis/gl-mesh3d#12 generate a few diffs in our image tests: Most notably compared to on master (see http://rickyreusser.com/plotly-mock-viewer/#gl3d_log-axis) |
Since all tests are passing at plotly/plotly.js#2293, merging. |
We have to unbind gl-vao's in order to avoid warnings in console, which was the issue preventing from bumping gl-shader version. Still have to figure out why it happens so with unbound gl-vao, but here it is must-do patch.
TODO:
Supercedes #10
@etpinard I can do patches to according repos to unlock gl-shader version